char -> std::byte

src/tcp.cpp

@@ -321,7 +321,7 @@ void NonBlockingClient::disconnect() {
 }
 
 [[nodiscard]] std::expected<int, int>
-NonBlockingClient::send(std::span<const char> data) {
+NonBlockingClient::send(std::span<const std::byte> data) {
     // TODO: Do we need this?
     auto conRes = get_last_connection_status();
     if (!conRes) return std::unexpected{conRes.error()};
@@ -359,7 +359,7 @@ bool NonBlockingClient::data_available() {
 }
 
 [[nodiscard]] std::expected<int, int>
-NonBlockingClient::recv(std::span<char> buffer) {
+NonBlockingClient::recv(std::span<std::byte> buffer) {
     const int bytesReceived =
         ::recv(m_socket, (char*)buffer.data(), buffer.size(), 0);
 

src/tcp.hpp

@@ -98,9 +98,8 @@ public:
 
     bool data_available();
 
-    // TODO: Make this std::byte
-    [[nodiscard]] std::expected<int, int> recv(std::span<char> buffer);
-    [[nodiscard]] std::expected<int, int> send(std::span<const char> data);
+    [[nodiscard]] std::expected<int, int> recv(std::span<std::byte> buffer);
+    [[nodiscard]] std::expected<int, int> send(std::span<const std::byte> data);
 
 private:
     int    m_socket = -1;