Formatting & commented out do_count_digits_decimal()

Reviewed-on: http://git.mercurial-manifold.eu/an.tsouchlos/const_fmt/pulls/10

const_fmt/format.h

@@ -66,16 +66,13 @@ constexpr inline void format_arg(char* dest, const char* arg) {
 };
 
 
-// End of recursion
-template <auto ast>
-constexpr inline void format_args(char*) {
-}
-
 template <auto fmt_data_array, typename first_arg_t, typename... args_t>
 constexpr inline void format_args(char* dest, first_arg_t first_arg,
                                   args_t... args) {
     format_arg<fmt_data_array[0]>(dest + fmt_data_array[0].position, first_arg);
-    format_args<drop_first(fmt_data_array)>(dest, args...);
+
+    if constexpr(fmt_data_array.size() > 1)
+        format_args<drop_first(fmt_data_array)>(dest, args...);
 }
 
 

const_fmt/format_impl.h

@@ -51,7 +51,9 @@ inline int do_count_digits_decimal(uint64_t n) {
         6,  6,  6,  7,  7,  7,  7,  8,  8,  8,  9,  9,  9,  10, 10, 10,
         10, 11, 11, 11, 12, 12, 12, 13, 13, 13, 13, 14, 14, 14, 15, 15,
         15, 16, 16, 16, 16, 17, 17, 17, 18, 18, 18, 19, 19, 19, 19, 20};
-    auto                            t = bsr2log10[__builtin_clzll(n | 1) ^ 63];
+
+    auto t = bsr2log10[__builtin_clzll(n | 1) ^ 63];
+
     static constexpr const uint64_t zero_or_powers_of_10[] = {
         0, 0, FMT_POWERS_OF_10(1U), FMT_POWERS_OF_10(1000000000ULL),
         10000000000000000000ULL};
@@ -80,9 +82,9 @@ constexpr inline auto count_digits_base(uint64_t n) -> int {
 
             return (result + count_digits_base<FormatType::b>(n));
         } else {
-            if (!std::is_constant_evaluated()) {
+//            if (!std::is_constant_evaluated()) {
-                return do_count_digits_decimal(n);
+//                return do_count_digits_decimal(n);
-            }
+//            }
             return count_digits_decimal_fallback(n);
         }
     }
@@ -161,7 +163,7 @@ constexpr inline void format_base(char* out, uint_t value, int n_digits,
     }
 
     if (value < divisor) {
-        *--out = digits2_base<t_format_type>(value*divisor)[0];
+        *--out = digits2_base<t_format_type>(value * divisor)[0];
         return;
     }
 

const_fmt/stdlib.h

@@ -187,8 +187,11 @@ concept floating_point = is_floating_point_v<type_t>;
 
 
 template <typename input_t, typename output_t>
-constexpr inline void copy(input_t* start, input_t* end, output_t* dest_start) {
+constexpr inline void copy(const input_t* start, const input_t* end,
-    memcpy(start, dest_start, end - start);
+                           output_t* dest_start) {
+    auto temp = start;
+    while (temp != end)
+        *(dest_start++) = *(temp++);
 }
 
 
@@ -234,14 +237,11 @@ public:
         static_assert(sizeof...(args) == t_size, "Invalid number of arguments");
     }
 
-    constexpr array() noexcept = default;
+    constexpr array() noexcept    = default;
-
+    constexpr array(const array&) = default;
-    constexpr array(array&) = default;
+    constexpr array(array&&)      = default;
-
-    constexpr array(array&&) = default;
-
-    constexpr array& operator=(array& other) = default;
 
+    constexpr array& operator=(const array& other) = default;
     constexpr array& operator=(array&& other) = default;
 
     constexpr void swap(array<data_t, t_size>& other) noexcept {
@@ -251,6 +251,9 @@ public:
         }
     }
 
+    constexpr std::size_t size() const noexcept {
+        return t_size;
+    }
 
     constexpr data_t& operator[](std::size_t index) noexcept {
         return m_data[index];
@@ -272,6 +275,14 @@ public:
         return (&(m_data[t_size - 1]) + 1);
     }
 
+    constexpr const_iterator begin() const noexcept {
+        return &(m_data[0]);
+    }
+
+    constexpr const_iterator end() const noexcept {
+        return (&(m_data[t_size - 1]) + 1);
+    }
+
     constexpr const_iterator cbegin() const noexcept {
         return &(m_data[0]);
     }